zhuzhurk commented on a change in pull request #7255: [FLINK-10945] Use
InputDependencyConstraint to avoid resource dead…
URL: https://github.com/apache/flink/pull/7255#discussion_r248145667
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex.java
##########
@@ -746,23 +750,16 @@ public boolean checkInputDependencyConstraints() {
}
/**
- * An input is consumable when
- * 1. the source result is PIPELINED and one of the result partition
has produced data.
- * 2. the source result is BLOCKING and is FINISHED(all partitions are
FINISHED).
+ * Get whether an input of the vertex is consumable.
+ * An input is consumable when when any partition in it is consumable.
+ *
+ * Note that a BLOCKING result partition is only consumable when all
partitions in the result are FINISHED.
*
* @return whether the input is consumable
*/
public boolean isInputConsumable(int inputNumber) {
Review comment:
Changed it to default scope as it will be invoked by `Execution` and tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
