StefanRRichter commented on a change in pull request #7351: [FLINK-11008][State
Backends, Checkpointing]SpeedUp upload state files using multithread
URL: https://github.com/apache/flink/pull/7351#discussion_r248269042
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
##########
@@ -218,7 +218,10 @@
private final boolean enableIncrementalCheckpointing;
/** Thread number used to download from DFS when restore. */
- private final int restoringThreadNum;
+ private final int numberOfRestoringThreads;
+
+ /** Thread number used to upload to DFS when snapshot. */
+ private final int numberOfSnapshottingThreads;
Review comment:
Do you think it makes sense that user can configure both numbers
independently? It might give more flexibility, but also makes it harder to
configure or maybe a user can forget to set one of the two values. Did you
experience scenarios where it made sense to have not just one number of io
threads?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
