StefanRRichter commented on a change in pull request #7351: [FLINK-11008][State 
Backends, Checkpointing]SpeedUp upload state files using multithread
URL: https://github.com/apache/flink/pull/7351#discussion_r248270611
 
 

 ##########
 File path: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDbStateDataTransfer.java
 ##########
 @@ -61,6 +80,116 @@ static void transferAllStateDataToDirectory(
                downloadDataForAllStateHandles(miscFiles, dest, 
restoringThreadNum, closeableRegistry);
        }
 
+       /**
+        * Upload all the files to checkpoint fileSystem using specified number 
of threads.
+        *
+        * @param files The files will be uploaded to checkpoint filesystem.
+        * @param numberOfSnapshottingThreads The number of threads used to 
upload the files.
+        * @param checkpointStreamFactory The checkpoint streamFactory used to 
create outputstream.
+        * @param closeableRegistry
 
 Review comment:
   Missing javadoc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to