zentol commented on a change in pull request #7455: [FLINK-11288][build]
Exclude flink-ml from flink-dist
URL: https://github.com/apache/flink/pull/7455#discussion_r248312152
##########
File path: flink-dist/src/main/assemblies/opt.xml
##########
@@ -75,14 +75,6 @@
<fileMode>0644</fileMode>
</file>
- <!-- ML -->
- <file>
-
<source>../flink-libraries/flink-ml/target/flink-ml_${scala.binary.version}-${project.version}-jar-with-dependencies.jar</source>
- <outputDirectory>opt/</outputDirectory>
-
<destName>flink-ml_${scala.binary.version}-${project.version}.jar</destName>
- <fileMode>0644</fileMode>
- </file>
-
Review comment:
I brought up that very point in the JIRA. The reasons for doing are listed
in the PR description.
The user would have to build flink-ml himself and put it into /lib. The
scala-shell may be removed in the future given that it is currently broken for
scala 2.12. The same applies to flink-ml since it is virtually frozen; instead
we'd opt for users manually adding it to the distribution.
In fact I'd very much like to transition to a model where users add the
things they need to flink-dist themselves. There's little benefit to having
everything in flink-dist; why bundle all reporters/libraries etc. if only a 1
or 2 of them are used anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
