tillrohrmann commented on a change in pull request #7568: [FLINK-11417] Make
access to ExecutionGraph single threaded from JobMaster main thread
URL: https://github.com/apache/flink/pull/7568#discussion_r250621326
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
##########
@@ -1224,10 +1260,10 @@ private void sendCancelRpcCall() {
cancelResultFuture.whenCompleteAsync(
(ack, failure) -> {
if (failure != null) {
- fail(new Exception("Task could
not be canceled.", failure));
+ failSync(new Exception("Task
could not be canceled.", failure));
Review comment:
This is not strictly related to this PR but I'm wondering whether the
`FutureUtils.retry` couldn't also use the main thread executor. The
`TaskExecutorGateway#cancelTask` should be non blocking and therefore it should
be ok to execute the call from the main thread. This could be a follow-up which
would allow us to get rid of the `executor` (together with the same change in
the `stop` method).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
