tillrohrmann commented on a change in pull request #7568: [FLINK-11417] Make
access to ExecutionGraph single threaded from JobMaster main thread
URL: https://github.com/apache/flink/pull/7568#discussion_r250603863
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##########
@@ -1789,4 +1845,10 @@ void notifyExecutionChange(
}
}
}
+
+ public void assertRunningInJobMasterMainThread() {
+ if (!(jobMasterMainThreadExecutor instanceof
ComponentMainThreadExecutor.DummyComponentMainThreadExecutor)) {
Review comment:
Why do we check here whether it is a `DummyComponentMainThreadExecutor`? Do
we have places where we sometimes want to call
`DummyComponentMainThreadExecutor#assertRunningInMainThread()` and others not
(like here)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
