tillrohrmann commented on a change in pull request #7568: [FLINK-11417] Make
access to ExecutionGraph single threaded from JobMaster main thread
URL: https://github.com/apache/flink/pull/7568#discussion_r250627188
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##########
@@ -1025,7 +1050,7 @@ public void cancel() {
// we build a future that is complete
once all vertices have reached a terminal state
final ConjunctFuture<Void> allTerminal
= FutureUtils.waitForAll(futures);
- allTerminal.whenComplete(
+ allTerminal.whenCompleteAsync(
Review comment:
The async part should not be necessary if the `releaseFuture` of the
`Execution` is always being completed from the main thread. According to the
JavaDocs this should be the case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
