tillrohrmann commented on a change in pull request #7568: [FLINK-11417] Make
access to ExecutionGraph single threaded from JobMaster main thread
URL: https://github.com/apache/flink/pull/7568#discussion_r250712434
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphCoLocationRestartTest.java
##########
@@ -51,6 +51,9 @@
@Test
public void testConstraintsAfterRestart() throws Exception {
+
Review comment:
I think in the `ExecutionGraphCoLocationRestartTest` it is not necessary to
use a proper `SlotPool`. Instead we could use a `TestingSlotProvider` which
always returns completed futures. Then we could use
`TestComponentMainThreadExecutor#forMainThread` and would not need to wrap the
methods in the `execute` calls.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
