tillrohrmann commented on a change in pull request #7568: [FLINK-11417] Make
access to ExecutionGraph single threaded from JobMaster main thread
URL: https://github.com/apache/flink/pull/7568#discussion_r252277192
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionVertexDeploymentTest.java
##########
@@ -277,9 +278,10 @@ public void testFailExternallyDuringDeploy() {
assertEquals(ExecutionState.FAILED,
vertex.getExecutionState());
assertEquals(testError, vertex.getFailureCause());
- queue.triggerNextAction();
- queue.triggerNextAction();
+// queue.triggerNextAction();
+// queue.triggerNextAction();
+ Assert.assertTrue(queue.isEmpty());
Review comment:
I think we can remove the `queue` altogether and replace the `SimpleSlot`
(and `Instance`) with a `TestingLogicalSlot` which uses a `TaskManagerGateway`
which returns an uncompleted future on `TaskManagerGateway#submitTask`. Then we
simulate the same behaviour.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
