StefanRRichter commented on a change in pull request #7568: [FLINK-11417] Make 
access to ExecutionGraph single threaded from JobMaster main thread
URL: https://github.com/apache/flink/pull/7568#discussion_r251475289
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
 ##########
 @@ -1789,4 +1845,10 @@ void notifyExecutionChange(
                        }
                }
        }
+
+       public void assertRunningInJobMasterMainThread() {
+               if (!(jobMasterMainThreadExecutor instanceof 
ComponentMainThreadExecutor.DummyComponentMainThreadExecutor)) {
 
 Review comment:
   I think this is required as long as execution graph building is also 
happening before the main thread is initialized via start.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to