pnowojski commented on a change in pull request #7199: [FLINK-10662][network]
Refactor the ChannelSelector interface for single selected channel
URL: https://github.com/apache/flink/pull/7199#discussion_r251494524
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/BatchTask.java
##########
@@ -1250,8 +1250,11 @@ public static void logAndThrowException(Exception ex,
AbstractInvokable parent)
oe = new OutputEmitter<T>(strategy,
indexInSubtaskGroup, comparator, partitioner, dataDist);
}
- final RecordWriter<SerializationDelegate<T>>
recordWriter =
- new
RecordWriter<SerializationDelegate<T>>(task.getEnvironment().getWriter(outputOffset
+ i), oe);
+ final RecordWriter<SerializationDelegate<T>>
recordWriter = RecordWriter.createRecordWriter(
+ task.getEnvironment().getWriter(outputOffset +
i),
+ oe,
+ -1,
Review comment:
another nit/tiny issue: here `-1` constant is leaking from the
`RecordWriter`. Maybe overloading `createRecordWriter()` with default value of
the `timeout`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
