pnowojski commented on a change in pull request #7199: [FLINK-10662][network]
Refactor the ChannelSelector interface for single selected channel
URL: https://github.com/apache/flink/pull/7199#discussion_r251489979
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ChannelSelector.java
##########
@@ -37,12 +37,19 @@
void setup(int numberOfChannels);
/**
- * Returns the logical channel indexes, to which the given record
should be
+ * Returns the logical channel index, to which the given record should
be
Review comment:
Add:
```
It is illegal to call `selectChannel` method for broadcast channel selectors
and this method can remain not implemented in that case (for example by
throwing {@link UnsupportedOperationException}).
```
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
