azagrebin commented on a change in pull request #7567: [FLINK-11358][tests]
Port LeaderChangeStateCleanupTest to new code base
URL: https://github.com/apache/flink/pull/7567#discussion_r251440897
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/embedded/EmbeddedLeaderService.java
##########
@@ -249,19 +252,22 @@ void confirmLeader(final EmbeddedLeaderElectionService
service, final UUID leade
}
}
+ void notifyAllListeners(String address, UUID leaderSessionId) {
+ for (EmbeddedLeaderRetrievalService listener : listeners) {
+ notifyListener(address, leaderSessionId,
listener.listener);
+ }
+ }
+
@GuardedBy("lock")
- private void updateLeader() {
+ void updateLeader() {
Review comment:
can it not stay private? also some other methods are not private
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
