azagrebin commented on a change in pull request #7567: [FLINK-11358][tests] 
Port LeaderChangeStateCleanupTest to new code base
URL: https://github.com/apache/flink/pull/7567#discussion_r251437510
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/embedded/EmbeddedLeaderService.java
 ##########
 @@ -48,7 +49,7 @@
 
        private static final Logger LOG = 
LoggerFactory.getLogger(EmbeddedLeaderService.class);
 
-       private final Object lock = new Object();
+       protected final Object lock = new Object();
 
 Review comment:
   is the `lock` used outside of `EmbeddedLeaderService` to be `protected`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to