tzulitai commented on issue #7020: [FLINK-10774] [Kafka] connection leak when 
partition discovery is disabled an…
URL: https://github.com/apache/flink/pull/7020#issuecomment-458401552
 
 
   @stevenzwu I've looked at @tillrohrmann's branch which contains the 
refactoring, and I think it solves the problem with the partition discoverer 
not being closed. The partition discoverer will now always be closed in the 
`close` method:
   
https://github.com/tillrohrmann/flink/commit/838b3d5fbf7a495c3d1e9124dc8e7215312ac84f#diff-06bf4a7f73d98ef91309154654563475R781
   
   There's also a test for that:
   
https://github.com/tillrohrmann/flink/commit/838b3d5fbf7a495c3d1e9124dc8e7215312ac84f#diff-30f04babc7ed166a0787a393a3573121R465

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to