tzulitai commented on issue #7020: [FLINK-10774] [Kafka] connection leak when partition discovery is disabled an… URL: https://github.com/apache/flink/pull/7020#issuecomment-458402620 @tillrohrmann changes in your branch looks good 👍 The tests you added also verifies that the changes fixes the following 3 scenarios (if I understood correctly): - Partition discoverer is always closed when open method throws exception - Partition discoverer is always closed if fetcher throws exception (either creation of the fetcher, or the fetch loop) - Partition discoverer is always closed on normal termination I've added some additional changes here: https://github.com/tillrohrmann/flink/pull/8 The changes refactors the new tests a bit to have consistent life cycle verifications. Also, it adds some test coverage that the discoverer is waked up before being closed in the scenario that the discoverer will be concurrently accessed (i.e., after the discovery loop has started). All in all, this LGTM on my side.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
