tzulitai commented on a change in pull request #7590: [FLINK-11329][core]
Migrating CompositeSerializers
URL: https://github.com/apache/flink/pull/7590#discussion_r252128802
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateFactory.java
##########
@@ -126,15 +128,15 @@ private IS createState() throws Exception {
@SuppressWarnings("unchecked")
private IS createValueState() throws Exception {
ValueStateDescriptor<TtlValue<SV>> ttlDescriptor = new
ValueStateDescriptor<>(
- stateDesc.getName(), new
TtlSerializer<>(stateDesc.getSerializer()));
+ stateDesc.getName(), new
TtlSerializer<>(LongSerializer.INSTANCE, stateDesc.getSerializer()));
Review comment:
As mentioned above, having to pass in a `LongSerializer.INSTANCE` every time
we're instantiating a TtlSerializer seems very redundant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
