tzulitai commented on a change in pull request #7590: [FLINK-11329][core]
Migrating CompositeSerializers
URL: https://github.com/apache/flink/pull/7590#discussion_r252128501
##########
File path:
flink-end-to-end-tests/flink-stream-state-ttl-test/src/main/java/org/apache/flink/streaming/tests/verify/ValueWithTs.java
##########
@@ -56,8 +57,8 @@ public String toString() {
/** Serializer for Serializer. */
public static class Serializer extends
CompositeSerializer<ValueWithTs<?>> {
- public Serializer(TypeSerializer<?> userValueSerializer) {
- super(true, userValueSerializer,
LongSerializer.INSTANCE);
+ public Serializer(TypeSerializer<?> valueSerializer,
TypeSerializer<Long> timestampSerializer) {
Review comment:
I don't think we need a public constructor that accepts the timestamp
serializer.
This should be a private constructor used only by the snapshot class.
We should still have a public constructor that accepts the user value
serializer, and by default just uses `LongSerializer.INSTANCE` as the new
timestamp serializer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
