tzulitai commented on a change in pull request #7590: [FLINK-11329][core]
Migrating CompositeSerializers
URL: https://github.com/apache/flink/pull/7590#discussion_r252145959
##########
File path:
flink-scala/src/main/scala/org/apache/flink/api/scala/typeutils/OptionSerializer.scala
##########
@@ -101,45 +101,8 @@ class OptionSerializer[A](val elemSerializer:
TypeSerializer[A])
// Serializer configuration snapshotting & compatibility
//
--------------------------------------------------------------------------------------------
- override def snapshotConfiguration(): ScalaOptionSerializerConfigSnapshot[A]
= {
- new ScalaOptionSerializerConfigSnapshot[A](elemSerializer)
- }
-
- override def ensureCompatibility(
- configSnapshot: TypeSerializerConfigSnapshot[_]):
CompatibilityResult[Option[A]] = {
-
- configSnapshot match {
- case optionSerializerConfigSnapshot
- : ScalaOptionSerializerConfigSnapshot[A] =>
- ensureCompatibilityInternal(optionSerializerConfigSnapshot)
- case legacyOptionSerializerConfigSnapshot
- : OptionSerializer.OptionSerializerConfigSnapshot[A] =>
Review comment:
Removing this path will lead to problems when restoring from Flink 1.3,
because this snapshot class was used back in Flink 1.3.
OTOH, it should be possible to redirect `OptionSerializerConfigSnapshot`'s
compatibility check to the new `ScalaOptionSerializerSnapshot`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
