Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37987162
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -536,6 +541,68 @@ public int compare(JobStatusMessage o1,
JobStatusMessage o2) {
}
/**
+ * Executes the STOP action.
+ *
+ * @param args Command line arguments for the stop action.
+ */
+ protected int stop(String[] args) {
+ LOG.info("Running 'stop' command.");
+
+ StopOptions options;
+ try {
+ options = CliFrontendParser.parseStopCommand(args);
+ } catch (CliArgsException e) {
+ return handleArgException(e);
+ } catch (Throwable t) {
+ return handleError(t);
+ }
+
+ // evaluate help flag
+ if (options.isPrintHelp()) {
+ CliFrontendParser.printHelpForStop();
+ return 0;
+ }
+
+ String[] stopArgs = options.getArgs();
+ JobID jobId;
+
+ if (stopArgs.length > 0) {
+ String jobIdString = stopArgs[0];
+ try {
+ jobId = new
JobID(StringUtils.hexStringToByte(jobIdString));
+ } catch (Exception e) {
+ LOG.error("Error: The value for the Job ID is
not a valid ID.");
+ System.out.println("Error: The value for the
Job ID is not a valid ID.");
+ return 1;
+ }
+ } else {
+ LOG.error("Missing JobID in the command line
arguments.");
+ System.out.println("Error: Specify a Job ID to stop a
job.");
+ return 1;
+ }
+
+ try {
+ ActorGateway jobManager = getJobManagerGateway(options);
+ Future<Object> response = jobManager.ask(new
StopJob(jobId), askTimeout);
+
+ try {
+ Await.result(response, askTimeout);
+
+ Object rc = response.value().get().get();
+ if(rc instanceof StoppingFailure) {
+ throw ((StoppingFailure)rc).cause();
+ }
+
+ return 0;
+ } catch (Exception e) {
+ throw new Exception("Stopping the job with ID "
+ jobId + " failed.", e);
+ }
+ } catch (Throwable t) {
--- End diff --
Do we really want to catch `Throwables` here? This will also catch `Errors`
such as OOM etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
