tillrohrmann commented on a change in pull request #7568: [FLINK-11417] Make
access to ExecutionGraph single threaded from JobMaster main thread
URL: https://github.com/apache/flink/pull/7568#discussion_r252277844
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionVertexDeploymentTest.java
##########
@@ -328,14 +330,17 @@ public void testFailCallOvertakesDeploymentAnswer() {
cancel1.run();
// execute the FutureUtils.retry loop (will complete
immediately)
- queue.triggerNextAction();
- // execute the exceptionallyAsync call in
Execution#sendRpcCall which won't don anything
- queue.triggerNextAction();
+// queue.triggerNextAction();
+// // execute the exceptionallyAsync call in
Execution#sendRpcCall which won't don anything
+// queue.triggerNextAction();
deploy.run();
- // execute exceptionallyAsync call in
Execution#deployToSlot
- queue.triggerNextAction();
+// // execute exceptionallyAsync call in
Execution#deployToSlot
+// queue.triggerNextAction();
+//
+// // handle returning interaction with TM gateway
+// queue.triggerNextAction();
Review comment:
I think this test can be removed because RPCs can no longer overtake each
other.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
