StefanRRichter commented on a change in pull request #7163: [FLINK-10471][State
TTL] State TTL cleanup using RocksDb compaction filter
URL: https://github.com/apache/flink/pull/7163#discussion_r253482964
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
##########
@@ -249,12 +252,14 @@
*/
private RocksDBSerializedCompositeKeyBuilder<K> sharedRocksKeyBuilder;
+ private final RocksDbTtlCompactFiltersManager ttlCompactFiltersManager;
+
public RocksDBKeyedStateBackend(
String operatorIdentifier,
ClassLoader userCodeClassLoader,
File instanceBasePath,
DBOptions dbOptions,
- ColumnFamilyOptions columnFamilyOptions,
+ Supplier<ColumnFamilyOptions> columnFamilyOptionsSupplier,
Review comment:
Hmm, a bit off-topic but if we already need to create CFO per state, maybe
it would be nice for user if this was a function `state name -> CFO` so that
they can have their factory produce different setting in the CFO by state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
