StefanRRichter commented on a change in pull request #7163: [FLINK-10471][State
TTL] State TTL cleanup using RocksDb compaction filter
URL: https://github.com/apache/flink/pull/7163#discussion_r251877778
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
##########
@@ -421,16 +427,29 @@ public void dispose() {
// invalidate the reference
db = null;
- IOUtils.closeQuietly(columnOptions);
IOUtils.closeQuietly(dbOptions);
IOUtils.closeQuietly(writeOptions);
+
+ for (RocksDbKvStateInfo kvStateInfo :
kvStateInformation.values()) {
+
IOUtils.closeQuietly(kvStateInfo.compactionFilterFactory);
Review comment:
Why are we doing the close here and not combined with the first iteration
over `kvStateInformation.values()` to close the column families? Maybe you
could rewrite to a `disposeRocksDbKvStateInfo(...)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
