tillrohrmann commented on a change in pull request #7568: [FLINK-11417] Make
access to ExecutionGraph single threaded from JobMaster main thread
URL: https://github.com/apache/flink/pull/7568#discussion_r253452025
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ConcurrentFailoverStrategyExecutionGraphTest.java
##########
@@ -183,27 +198,26 @@ public void testGlobalFailureConcurrentToLocalFailover()
throws Exception {
assertEquals(JobStatus.RUNNING, graph.getState());
// let one of the vertices fail - that triggers a local
recovery action
- vertex1.getCurrentExecutionAttempt().fail(new Exception("test
failure"));
+ vertex1.getCurrentExecutionAttempt().failSync(new
Exception("test failure"));
assertEquals(ExecutionState.FAILED,
vertex1.getCurrentExecutionAttempt().getState());
// graph should still be running and the failover recovery
action should be queued
assertEquals(JobStatus.RUNNING, graph.getState());
- assertEquals(1, executor.numQueuedRunnables());
// now cancel the job
- graph.failGlobal(new Exception("test exception"));
+ graph.failGlobal(new SuppressRestartsException(new
Exception("test exception")));
assertEquals(JobStatus.FAILING, graph.getState());
assertEquals(ExecutionState.FAILED,
vertex1.getCurrentExecutionAttempt().getState());
assertEquals(ExecutionState.CANCELING,
vertex2.getCurrentExecutionAttempt().getState());
// let the recovery action continue
- executor.trigger();
+ blocker.complete(null);
// now report that cancelling is complete for the other vertex
vertex2.getCurrentExecutionAttempt().cancelingComplete();
- assertEquals(JobStatus.FAILED, graph.getState());
+ waitUntilJobStatus(graph, JobStatus.FAILED, 1000L);
Review comment:
do we need to wait for this job transition or is it already transitioned
when we are at this point?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
