tillrohrmann commented on a change in pull request #7568: [FLINK-11417] Make
access to ExecutionGraph single threaded from JobMaster main thread
URL: https://github.com/apache/flink/pull/7568#discussion_r253480516
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphRestartTest.java
##########
@@ -608,12 +569,11 @@ public void run() {
completeCancellingForAllVertices(eg);
- // block the restart until we have completed for all vertices
the cancellation
- // otherwise it might happen that the last vertex which failed
will have a new
- // execution set due to restart which is wrongly canceled
- restartLatch.trigger();
+ // Now trigger the restart
+ Assert.assertEquals(1,
triggeredRestartStrategy.getNumberOfQueuedActions());
+ triggeredRestartStrategy.triggerAll().join();
- waitUntilJobStatus(eg, JobStatus.RUNNING, 1000);
+ Assert.assertEquals(JobStatus.RUNNING, eg.getState());
waitForTasksAfterRestart.getFuture().get(1000,
TimeUnit.MILLISECONDS);
Review comment:
Same here, do we still need this wait call?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
