[
https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14714199#comment-14714199
]
ASF GitHub Bot commented on FLINK-2111:
---------------------------------------
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-135075011
Thanks for your review. I will add some more answers to the specific
comments (if necessary) and address all others. Do you want me to put a new
commit on top or should I squash directly?
About stop-failure-issue: need to think about it. But the "stop" signal is
intended to be a *request* to the streaming job to shut down. Thus, it's no
"hard" command. Furthermore, "stop" is idempotent -- for the failures case, if
the job is still in "stopping" mode after restart but does not stop, the "stop"
signal can just be sent a second time... Not sure if this is "good enough"?
> Add "stop" signal to cleanly shutdown streaming jobs
> ----------------------------------------------------
>
> Key: FLINK-2111
> URL: https://issues.apache.org/jira/browse/FLINK-2111
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Runtime, JobManager, Local Runtime,
> Streaming, TaskManager, Webfrontend
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Priority: Minor
>
> Currently, streaming jobs can only be stopped using "cancel" command, what is
> a "hard" stop with no clean shutdown.
> The new introduced "stop" signal, will only affect streaming source tasks
> such that the sources can stop emitting data and shutdown cleanly, resulting
> in a clean shutdown of the whole streaming job.
> This feature is a pre-requirment for
> https://issues.apache.org/jira/browse/FLINK-1929
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
