Myasuka commented on issue #7586: [FLINK-10912][rocksdb] Configurable RocksDBStateBackend options URL: https://github.com/apache/flink/pull/7586#issuecomment-461721118 @StefanRRichter Thanks a lot for your reviewing. I'd try to summarize your idea and record my thoughts below: 1. Configurable `PredefinedOptions` and `OptionsFactory`. In this PR, I support to configure `PredefinedOptions` but `OptionsFactory` just kept only interface as the same as before. Just as original JIRA talked, we could make `OptionsFactory` also configurable. 1. Still two level hierarchy to parse RocksDB's options. In this PR, I previously introduced `RocksDBCustomizedOptions` between `PredefinedOptions` and `OptionsFactory`. Actually, the role of `RocksDBCustomizedOptions` played could be acted as `OptionsFactory`. I think the default implementation of `OptionsFactory` could be achieved as the combination of `RocksDBCustomizedOptions#fromConfig(Configuration)`, `RocksDBCustomizedOptions#getDBOptions(DBOptions)` and `RocksDBCustomizedOptions#getColumnOptions(ColumnFamilyOptions)` in this PR. From what I understood, the behavior for users to configure only through `flink-conf.yaml` did not change from current PR committed, even though we would support configurable `OptionsFactory` then. They still configure these options introduced within current `RocksDBCustomizedOptions`, but we then translated the default implementation of `OptionsFactory`. Did I understand correctly?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
