Myasuka commented on issue #7586: [FLINK-10912][rocksdb] Configurable RocksDBStateBackend options URL: https://github.com/apache/flink/pull/7586#issuecomment-465163197 1. I introduce `UserConfiguredOptionsFactory` because when `configure` the state backend, we cannot get the `ClassLoader` which is located in `Environment`. I have to wrap the options factory first and lazily instantiate it. Any better solution is always welcome :) 2. I think we could rename current `ConfigurableOptionsFactory` as `DefaultConfigurableOptionsFactory` and introduce a interface `ConfigurableOptionsFactory` with a `fromConfig(Configuration)` method so that users could configure options-factory themselves from the flink-conf.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
