zentol commented on a change in pull request #7263: [FLINK-11081] Support
binding port range for REST server
URL: https://github.com/apache/flink/pull/7263#discussion_r255055853
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/entrypoint/YarnEntrypointUtils.java
##########
@@ -98,9 +98,9 @@ public static Configuration loadConfiguration(String
workingDirectory, Map<Strin
configuration.setInteger(WebOptions.PORT, 0);
}
- if (configuration.getInteger(RestOptions.PORT) >= 0) {
+ if
(!configuration.getString(RestOptions.BIND_PORT).equals("0")) {
Review comment:
This whole check seems unnecessary; if it is non-zero it is set to 0,
otherwise it was set to zero to being with. We can just always set this to 0,
without actually changing any behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
