zentol commented on a change in pull request #7263: [FLINK-11081] Support 
binding port range for REST server
URL: https://github.com/apache/flink/pull/7263#discussion_r255055344
 
 

 ##########
 File path: 
flink-yarn/src/main/java/org/apache/flink/yarn/entrypoint/YarnEntrypointUtils.java
 ##########
 @@ -98,9 +98,9 @@ public static Configuration loadConfiguration(String 
workingDirectory, Map<Strin
                        configuration.setInteger(WebOptions.PORT, 0);
                }
 
-               if (configuration.getInteger(RestOptions.PORT) >= 0) {
+               if 
(!configuration.getString(RestOptions.BIND_PORT).equals("0")) {
 
 Review comment:
   "00" is equivalent but would fail this check.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to