twalthr commented on a change in pull request #7664: [FLINK-11449][table]
Uncouple the Expression class from RexNodes.
URL: https://github.com/apache/flink/pull/7664#discussion_r255036770
##########
File path:
flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/OrcTableSource.java
##########
@@ -189,11 +189,11 @@ public TableSchema getTableSchema() {
}
@Override
- public TableSource<Row> applyPredicate(List<Expression> predicates) {
+ public TableSource<Row> applyPredicate(List<PlannerExpression>
predicates) {
Review comment:
The reason for having `Expression` in `flink-table-common` was to push
expressions into sources. In the future, sources will only need a
`flink-table-commmon` dependency. This source should use the function
definitions and not the planner expression.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
