twalthr commented on a change in pull request #7664: [FLINK-11449][table]
Uncouple the Expression class from RexNodes.
URL: https://github.com/apache/flink/pull/7664#discussion_r255065688
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
##########
@@ -414,15 +414,15 @@ abstract class BatchTableEnvironment(
* @tparam T The type of the [[DataSet]].
*/
protected def registerDataSetInternal[T](
- name: String, dataSet: DataSet[T], fields: Array[Expression]): Unit = {
+ name: String, dataSet: DataSet[T], fields: Array[PlannerExpression]):
Unit = {
Review comment:
If `PlannerExpression` would implement the `Expression` interface, we would
not need these big refactorings.
This also makes sense because a `PlannerExpression` is just a special kind
of expression, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
