twalthr commented on a change in pull request #7664: [FLINK-11449][table]
Uncouple the Expression class from RexNodes.
URL: https://github.com/apache/flink/pull/7664#discussion_r255067704
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/scala/windows.scala
##########
@@ -143,7 +143,31 @@ case class OverWindowWithOrderBy(partitionBy:
Seq[Expression], orderBy: Expressi
* @param alias alias for this over window
* @return over window
*/
- def as(alias: String): OverWindow =
as(ExpressionParser.parseExpression(alias))
+ def as(alias: Expression): OverWindow = {
+ org.apache.flink.table.api.scala.OverWindow(
+ alias, partitionBy, orderBy, UNBOUNDED_RANGE, CURRENT_RANGE)
+ }
+}
+
+/**
+ * Over window is similar to the traditional OVER SQL.
+ */
+case class OverWindow(
Review comment:
I don't understand the changes in this file. Please elaborate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
