tzulitai commented on a change in pull request #7576:
[FLINK-11046][elasticsearch] Fix ElasticSearch6Connector thread blocked when
index failed with retry
URL: https://github.com/apache/flink/pull/7576#discussion_r255293487
##########
File path:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchApiCallBridge.java
##########
@@ -93,6 +93,18 @@ default RequestIndexer createBulkProcessorIndexer(
numPendingRequestsRef);
}
+ /**
+ * Creates a {@link RequestIndexer} that is able to work with {@link
BulkProcessor} binary compatible.
+ */
+ default ElasticsearchFailureHandlerIndexer createFailureHandlerIndexer(
+ boolean flushOnCheckpoint,
+ AtomicLong numPendingRequestsRef) {
Review comment:
the fact that we require passing in the `numpendingRequestsRef` hints that
we might need to refactor this a bit ..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
