tzulitai commented on a change in pull request #7576:
[FLINK-11046][elasticsearch] Fix ElasticSearch6Connector thread blocked when
index failed with retry
URL: https://github.com/apache/flink/pull/7576#discussion_r255294329
##########
File path:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
##########
@@ -380,6 +384,15 @@ private void checkErrorAndRethrow() {
}
}
+ private void reindexFailedRequest() {
+ if (failureRequestIndexer.numberOfActions() > 0) {
+ BulkRequest failedRequest =
failureRequestIndexer.getBulkRequest();
+ for (ActionRequest request: failedRequest.requests()) {
+ requestIndexer.add(request);
Review comment:
this `add` variant is deprecated. Should avoid using deprecated methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
