sunjincheng121 commented on issue #7664: [FLINK-11449][table] Uncouple the 
Expression class from RexNodes.
URL: https://github.com/apache/flink/pull/7664#issuecomment-462260244
 
 
   Hi @twalthr Thanks for your valued comments! 
   
   I have been fixed all comments locally in addition to the comments which I 
have questions, especially the Expressions has already reduced from 21 to the 
9. You will see the changes after updating the PR. I would like to ask for your 
opinion: I am updating the existing improvements first, or  updating all the 
fix together after finish all the discussion?
   
   Thanks,
   Jincheng

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to