sunjincheng121 commented on issue #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes. URL: https://github.com/apache/flink/pull/7664#issuecomment-464031612 Hi @twalthr I updated the PR based on your comments. More updates with the latest commit: 1. Make PlannerExpression implements Expression 2. Add 'Expression' suffix name to all Expressions, e.g., Call to CallExpression, TableReference to TableReferenceExpression. 3. Revert package path change for PlannerExpression 4. Add AggregateCallExpression to avoid distinct on CallExpression directly which would bring chaos on Api. This is also consistent with the previous flink master. Note: We add the AggregateCallExpression to avoid the following chaos on Api: 1. Avoid multi distinct, e.g., 'a.sum.distinct.distinct 2. Avoid wrong order, e.g., 'a.distinct.sum 3. Avoid distinct on udf, e.g., 'a.udf.distinct Thank you again for your valuable comments and wish you a happy holiday. Best, Jincheng
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
