igalshilman commented on a change in pull request #7658: [FLINK-10493][core]
Migrating the TupleSerializerBase serializers family
URL: https://github.com/apache/flink/pull/7658#discussion_r255445999
##########
File path:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerSnapshot.java
##########
@@ -155,7 +155,7 @@ public final void readSnapshot(int readVersion,
DataInputView in, ClassLoader us
TypeSerializerSchemaCompatibility<T> internalResolveSchemaCompatibility(
TypeSerializer<T> newSerializer,
TypeSerializerSnapshot<?>[] snapshots) {
- if (newSerializer.getClass() != correspondingSerializerClass) {
+ if (!correspondingSerializerClass.isInstance(newSerializer)) {
Review comment:
I think that I've provide to Aljoscha the wrong example, the correct example
would be the anonymous case class serializer that returns
`SpecificCaseClassSerializerSnapshot` in `snapshotConfiguration`, which leads
to having a snapshot class that is not compatible with the serializer (without
the change)
But might be this is not a real issue since the checks goes in the other
direction (restored snapshot class vs new serializer)
If you think it is safe to drop it, then feel free to exclude this commit :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
