StefanRRichter commented on a change in pull request #7665: [FLINK-11551][rpc]
Allow RpcEndpoint to execute asynchronous stop operations
URL: https://github.com/apache/flink/pull/7665#discussion_r255030881
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/RpcEndpoint.java
##########
@@ -147,16 +147,19 @@ protected final void stop() {
* @return Future which is completed once all post stop actions are
completed. If an error
* occurs this future is completed exceptionally
*/
- public abstract CompletableFuture<Void> postStop();
+ public CompletableFuture<Void> onStop() {
Review comment:
Unrelated to the very change, but from the comment `IMPORTANT: This method
should never be called directly by the user`, I wonder if the interface should
not be split up in two parts, a user facing subset and the full interface with
such lifecycle methods that is only used in the `AkkaRpcActor`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
