StefanRRichter commented on a change in pull request #7665: [FLINK-11551][rpc]
Allow RpcEndpoint to execute asynchronous stop operations
URL: https://github.com/apache/flink/pull/7665#discussion_r255886303
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerRunner.java
##########
@@ -103,9 +103,7 @@ public void start() throws Exception {
@Override
public CompletableFuture<Void> closeAsync() {
synchronized (lock) {
Review comment:
I think this lock can go away completely if you touch this method. Seems
that the class can even use a bit more cleanup - lock not needed, field that
can be local variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
