tillrohrmann commented on a change in pull request #7665: [FLINK-11551][rpc]
Allow RpcEndpoint to execute asynchronous stop operations
URL: https://github.com/apache/flink/pull/7665#discussion_r255956511
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/RpcEndpoint.java
##########
@@ -147,16 +147,19 @@ protected final void stop() {
* @return Future which is completed once all post stop actions are
completed. If an error
* occurs this future is completed exceptionally
*/
- public abstract CompletableFuture<Void> postStop();
+ public CompletableFuture<Void> onStop() {
Review comment:
This would not solve the underlying problem that whenever you have access to
the class extending `RpcEndpoint` you would have access to this method as well.
In some way, we already have this separation with the `RpcGateway` and
`RpcEndpoint`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
