tillrohrmann commented on a change in pull request #7665: [FLINK-11551][rpc]
Allow RpcEndpoint to execute asynchronous stop operations
URL: https://github.com/apache/flink/pull/7665#discussion_r255961874
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
##########
@@ -1513,8 +1511,7 @@ public JobMasterGateway getGateway() {
@Override
public CompletableFuture<Void> closeAsync() {
- shutDown();
- return getTerminationFuture();
+ return terminate();
Review comment:
I think you're right and it would be better if `RpcEndpoint` would implement
`AutoCloseableAsync`. I'll update it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
