[ 
https://issues.apache.org/jira/browse/FLINK-2373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14716309#comment-14716309
 ] 

ASF GitHub Bot commented on FLINK-2373:
---------------------------------------

Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/1066#issuecomment-135348048
  
    Very good contribution. Thanks @akunft. The only thing would be to add a 
test which verifies that the configuration is actually used for starting the 
`JobClientActor's` `ActorSystem`, for example. We could set the framesize to 
something so small that the job execution must fail. Or we change the default 
parallelism as it is done in 
`ExecutionEnvironmnetITCase.testLocalEnvironmentWithConfig`.
    
    After adding the test, +1 for merging :-)


> Add configuration parameter to createRemoteEnvironment method
> -------------------------------------------------------------
>
>                 Key: FLINK-2373
>                 URL: https://issues.apache.org/jira/browse/FLINK-2373
>             Project: Flink
>          Issue Type: Bug
>          Components: other
>            Reporter: Andreas Kunft
>            Priority: Minor
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Currently there is no way to provide a custom configuration upon creation of 
> a remote environment (via ExecutionEnvironment.createRemoteEnvironment(...)).
> This leads to errors when the submitted job exceeds the default value for the 
> max. payload size in Akka, as we can not increase the configuration value 
> (akka.remote.OversizedPayloadException: Discarding oversized payload...)
> Providing an overloaded method with a configuration parameter for the remote 
> environment fixes that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to