Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1059#discussion_r38077040
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/api/common/io/GenericCsvInputFormat.java
 ---
    @@ -445,7 +445,12 @@ protected int skipFields(byte[] bytes, int startPos, 
int limit, byte[] delim) {
                        // quoted string parsing enabled and field is quoted
                        // search for ending quote character
                        i++;
    -                   while(i < limit && bytes[i] != quoteCharacter) {
    +
    +                   while(i < limit){
    +                           //quote character was escaped
    +                           if (bytes[i]==quoteCharacter && bytes[i-1]!=92){
    --- End diff --
    
    Can you define a constant `private static final byte BACKSLASH = 92` ? The 
compiler inlines those, and the code is more self explaining then.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to