Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1059#discussion_r38077190
  
    --- Diff: 
flink-java/src/test/java/org/apache/flink/api/java/io/CsvInputFormatTest.java 
---
    @@ -984,7 +984,7 @@ public void testPojoTypeWithInvalidFieldMapping() 
throws Exception {
        @Test
        public void testQuotedStringParsingWithIncludeFields() throws Exception 
{
                final String fileContent = "\"20:41:52-1-3-2015\"|\"Re: 
Taskmanager memory error in Eclipse\"|" +
    -                           "\"Blahblah 
<[email protected]>\"|\"bla\"|\"blubb\"";
    --- End diff --
    
    Let's not change old checks, but rather add new checks. You never know if 
you don't loose coverage of a critical case otherwise...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to