StefanRRichter commented on a change in pull request #7674: [FLINK-10043]
[State Backends] Refactor RocksDBKeyedStateBackend object
construction/initialization/restore code
URL: https://github.com/apache/flink/pull/7674#discussion_r256828555
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsStateBackend.java
##########
@@ -458,7 +460,8 @@ public CheckpointStorage createCheckpointStorage(JobID
jobId) throws IOException
KeyGroupRange keyGroupRange,
TaskKvStateRegistry kvStateRegistry,
TtlTimeProvider ttlTimeProvider,
- MetricGroup metricGroup) {
+ MetricGroup metricGroup,
+ Collection<KeyedStateHandle> stateHandles) {
Review comment:
Ideally, we could have first introduced the builder for all backends, where
the builder does nothing but 1) creating a new backend opject, 2) call
`restore(...)` on it. And then the second step could have been to really
refactor the builders. This would probably give the cleanest history. However,
if it is too complicated to rebase like this, I am also fine with refactoring
this part later oif we make sure the follow-up is done soon enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
