TisonKun commented on a change in pull request #7708: [WIP][FLINK-10569][tests]
Clean up uses of Scheduler and Instance in valid tests(Batch 2)
URL: https://github.com/apache/flink/pull/7708#discussion_r257451919
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphRestartTest.java
##########
@@ -740,49 +711,39 @@ public void testFailureWhileRestarting() throws
Exception {
// Utilities
//
------------------------------------------------------------------------
- private Scheduler createSchedulerWithInstances(int num,
TaskManagerGateway taskManagerGateway) {
+ private SlotProvider createSchedulerWithInstances(JobID jobID, int
slots) {
Review comment:
@tillrohrmann The last usage of Instance in valid tests is in this method. I
have no idea how to get rid of it. Could you take a look or give some advice?
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services