TisonKun commented on a change in pull request #7708: [WIP][FLINK-10569][tests] 
Clean up uses of Scheduler and Instance in valid tests(Batch 2)
URL: https://github.com/apache/flink/pull/7708#discussion_r257454052
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphRestartTest.java
 ##########
 @@ -740,49 +711,39 @@ public void testFailureWhileRestarting() throws 
Exception {
        //  Utilities
        // 
------------------------------------------------------------------------
 
-       private Scheduler createSchedulerWithInstances(int num, 
TaskManagerGateway taskManagerGateway) {
+       private SlotProvider createSchedulerWithInstances(JobID jobID, int 
slots) {
 
 Review comment:
   FYI, I break this pr into separated prs. But this help request is still 
valid :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to