StefanRRichter commented on a change in pull request #7674: [FLINK-10043]
[State Backends] Refactor RocksDBKeyedStateBackend object
construction/initialization/restore code
URL: https://github.com/apache/flink/pull/7674#discussion_r257634916
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
##########
@@ -256,90 +211,64 @@ public RocksDBKeyedStateBackend(
DBOptions dbOptions,
ColumnFamilyOptions columnFamilyOptions,
TaskKvStateRegistry kvStateRegistry,
- TypeSerializer<K> keySerializer,
+ StateSerializerProvider<K> keySerializerProvider,
int numberOfKeyGroups,
KeyGroupRange keyGroupRange,
ExecutionConfig executionConfig,
- boolean enableIncrementalCheckpointing,
int numberOfTransferingThreads,
- LocalRecoveryConfig localRecoveryConfig,
- RocksDBStateBackend.PriorityQueueStateType
priorityQueueStateType,
TtlTimeProvider ttlTimeProvider,
- RocksDBNativeMetricOptions metricOptions,
- MetricGroup metricGroup
- ) throws IOException {
-
- super(kvStateRegistry, keySerializer, userCodeClassLoader,
- numberOfKeyGroups, keyGroupRange, executionConfig,
ttlTimeProvider);
+ RocksDB db,
+ LinkedHashMap<String, StateColumnFamilyHandle>
kvStateInformation,
+ int keyGroupPrefixBytes,
+ CloseableRegistry cancelStreamRegistry,
+ StreamCompressionDecorator keyGroupCompressionDecorator,
+ ResourceGuard rocksDBResourceGuard,
+ RocksDBSnapshotStrategyBase checkpointSnapshotStrategy,
+ RocksDBSnapshotStrategyBase savepointSnapshotStrategy,
Review comment:
Use of raw-type
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
