StefanRRichter commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code URL: https://github.com/apache/flink/pull/7674#discussion_r257684891
########## File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/restore/RocksDBRestoreOperation.java ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.contrib.streaming.state.restore; + +import org.apache.flink.runtime.state.KeyedStateHandle; + +import org.rocksdb.RocksDB; + +import java.util.Collection; + +/** + * Interface for RocksDB restore. + * + * @param <K> The data type that the serializer serializes. + */ +public interface RocksDBRestoreOperation<K> { + /** + * Restores state that was previously snapshot-ed from the provided state handles. + * @param stateHandles List of all key groups state handles that shall be restored. + * @param db The db instance, need to create on if null + */ + RocksDBRestoreResult restore(Collection<KeyedStateHandle> stateHandles, RocksDB db) throws Exception; Review comment: After a second look, I even think that this could be another case where we can also rather supply the state handles and db in the constructor of the implementation and could reduce the method signature to `RocksDBRestoreResult restore() throws Exception;` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
